Closed janosh closed 10 months ago
All modified lines are covered by tests :white_check_mark:
Comparison is base (
8184d2d
) 91.34% compared to head (bcdae5a
) 91.34%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@janosh were the default values not properly populating for those fields? If they have auto-populating values, it isn't clear to me why they need to be optional.
They were not populated. pydantic
was complaining about NoneType
for all of them:
__pydantic_self__.__pydantic_validator__.validate_python(data, self_instance=__pydantic_self__)
pydantic_core._pydantic_core.ValidationError: 3 validation errors for TaskDoc
builder_meta.emmet_version
Input should be a valid string [type=string_type, input_value=None, input_type=NoneType]
For further information visit https://errors.pydantic.dev/2.4/v/string_type
builder_meta.pymatgen_version
Input should be a valid string [type=string_type, input_value=None, input_type=NoneType]
For further information visit https://errors.pydantic.dev/2.4/v/string_type
builder_meta.build_date
Input should be a valid datetime [type=datetime_type, input_value=None, input_type=NoneType]
For further information visit https://errors.pydantic.dev/2.4/v/datetime_type
These 3 fields were not optional and raising validation errors from being
None
inatomate2
tests.builder_meta.emmet_version
builder_meta.pymatgen_version
builder_meta.build_date
Causing 32 tests to fail on the
main
branch so newemmet
release this week would be much appreciated @munrojm! π@esoteric-ephemera @hrushikesh-s @Zhuoying