search

materialsproject / emmet

Be a master builder of databases of material properties. Avoid the Kragle.
https://materialsproject.github.io/emmet/
Other
52 stars 64 forks source link

fix custodian import #884

Closed JaGeo closed 9 months ago

JaGeo commented 9 months ago

@munrojm I somehow overlooked that custodian is not installed by emmet... Therefore, importing custodian fails. I would assume we do not want custodian as a dependency just for type checking.

Really sorry! I am currently using the mp-api and it is failing because of my latest change.

rkingsbury commented 9 months ago

I just noticed this too!

mattmcdermott commented 9 months ago

Referenced downstream here: https://github.com/materialsproject/api/issues/861