materialsproject / emmet

Be a master builder of databases of material properties. Avoid the Kragle.
https://materialsproject.github.io/emmet/
Other
52 stars 64 forks source link

Pydantic 2.5.0 breaks `from_vasp_files` #889

Closed Andrew-S-Rosen closed 9 months ago

Andrew-S-Rosen commented 9 months ago

Problem

Just making a note that Pydantic 2.5.0 seems to break TaskDoc.from_directory("/my/path").model_dump() for VASP runs as shown here.

Sorry, don't have time to do a more detailed bug report at the moment, but I will come back to this! Feel free to close if that's a problem or if you feel it's not related :)

Proposed Solution

TBD.

Alternatives

No response

Andrew-S-Rosen commented 9 months ago

Closing this because I cannot reproduce it in a minimal example. I will re-open once I can isolate the problem.