search

materialsproject / emmet

Be a master builder of databases of material properties. Avoid the Kragle.
https://materialsproject.github.io/emmet/
Other
51 stars 63 forks source link

Remove 'model_' from ML doc field names #924

Closed tsmathis closed 6 months ago

tsmathis commented 6 months ago

The fields model_name and model_version in the MLDoc clash with the protected namespace model_ that exists in Pydantic 2. See here, where the warning arises to prevent collisions with BaseModels methods.

Proposed fix is to change model_name and model_version to just name and model

tsmathis commented 6 months ago

@munrojm, per our discussion

codecov-commenter commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (fdbd3a4) 90.54% compared to head (8b77f16) 88.87%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #924 +/- ## ========================================== - Coverage 90.54% 88.87% -1.68% ========================================== Files 139 109 -30 Lines 13203 10048 -3155 ========================================== - Hits 11955 8930 -3025 + Misses 1248 1118 -130 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.