materialsproject / emmet

Be a master builder of databases of material properties. Avoid the Kragle.
https://materialsproject.github.io/emmet/
Other
51 stars 63 forks source link

[WIP] Large structural changes to MPcules #926

Open espottesmith opened 6 months ago

espottesmith commented 6 months ago

Meant to do this piecemeal, but there kept being things that I wanted/needed. Also, the main point was to make changes/fixes to the API, and that's actually one of the things I still need to mess with/test. Anyways, here we are.

Contributor Checklist

codecov-commenter commented 6 months ago

Codecov Report

Attention: Patch coverage is 91.21756% with 88 lines in your changes missing coverage. Please review.

Project coverage is 89.91%. Comparing base (f0c70f4) to head (4613ad9). Report is 1 commits behind head on main.

Files Patch % Lines
emmet-core/emmet/core/molecules/trajectory.py 81.18% 38 Missing :warning:
...et-builders/emmet/builders/molecules/trajectory.py 91.62% 16 Missing :warning:
...mmet-api/emmet/api/routes/molecules/tasks/utils.py 50.00% 11 Missing :warning:
...t/api/routes/molecules/electric/query_operators.py 76.92% 9 Missing :warning:
...mmet-builders/emmet/builders/molecules/electric.py 94.23% 6 Missing :warning:
emmet-core/emmet/core/molecules/electric.py 95.65% 4 Missing :warning:
emmet-core/emmet/core/molecules/orbitals.py 97.43% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #926 +/- ## ========================================== + Coverage 89.80% 89.91% +0.11% ========================================== Files 142 146 +4 Lines 13394 13468 +74 ========================================== + Hits 12028 12110 +82 + Misses 1366 1358 -8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

espottesmith commented 6 days ago

This is still WIP (will be contributing to it this week), but it'd be helpful at this point to have folks' eyes on it. @munrojm @orionarcher