Use `Literal` type hints for `CrystalSystem`

materialsproject / emmet

Be a master builder of databases of material properties. Avoid the Kragle.

https://materialsproject.github.io/emmet/

Other

53 stars 66 forks source link

Closed Andrew-S-Rosen closed 5 months ago

Andrew-S-Rosen commented 5 months ago

Switch from using a ValueEnum approach for CrystalSystem to Literal strings. Closes #914.

[X] I have broken down my PR scope into the following TODO tasks
- [X] task 1
- [X] task 2
[X] I have run the tests locally and they passed.
[X] I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR