search

materialsproject / fireworks

The Fireworks Workflow Management Repo.
https://materialsproject.github.io/fireworks
Other
361 stars 185 forks source link

Bug: DupeFinder verify() is not called! #310

Closed computron closed 5 years ago

computron commented 5 years ago

See: https://groups.google.com/forum/#!topic/fireworkflows/3ssKK4Q5JJU

for details. It looks like the needed code was removed at some point?

computron commented 5 years ago

The offending commit seems to be this one: 45f2c59ccbb2f4c95bd9c8c9c8e9060d21fdfb87

Need to look into whether this was a good change or not. If it is, we should at least remove verify() from DupeFinderBase to avoid confusion.

computron commented 5 years ago

Fixed via: c247e2de27e442dce2ec2fa17b242af6bd3c1eaf

I think Kiran removed the verify() originally for performance reasons. This solution retains performance when verify() is not used while still giving the ability to use verify()