search

materialsproject / fireworks

The Fireworks Workflow Management Repo.
https://materialsproject.github.io/fireworks
Other
361 stars 185 forks source link

Allow binary files in filepad #336

Closed jotelha closed 5 years ago

jotelha commented 5 years ago

So far, it has only been possible to store text files in the filepad. Trying to store binary files threw an error. This simple modification stores all files as binary in the filepad. However, the filepad behavior would change in such a way that the responsibility of correctly encoding / decoding text files is passed on to the user.

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 60.58% when pulling b0548035e4d959ef02b90a24d7449c575cbe6369 on jotelha:binaryFilesInFilepad into d970893acb9f1178cdc025d912fa363b56738cc9 on materialsproject:master.

computron commented 5 years ago

Thanks! I will merge but then add a flag to go back to "plain" mode if needed, e.g., if someone is working between Windows / Linux and needs to be able to write in file mode