Closed zhubonan closed 4 years ago
gunicorn.six is removed in gunicorn > 20.0
gunicorn.six
gunicorn > 20.0
This line here:
https://github.com/materialsproject/fireworks/blob/6505cd52ca3a7f34b549e6a18c7e2d0d336aa066/fireworks/flask_site/gunicorn.py#L7-L9
still tries to import iteritem from it. The easy fix is to tell it import from six instead.
iteritem
six
As a result, anyone with gunicorn>20.0 will get a message saying they need to install gunicorn.
gunicorn>20.0
gunicorn
As a general problem, I can see that setup.py only requires versions of dependencies to be higher than a particular release.
setup.py
https://github.com/materialsproject/fireworks/blob/e33821518acf4dc7276aa161a523a0770a776191/setup.py#L32-L37
If assuming semantic versioning, it would be better to pin them below the next major release number, in case of future non-compatible release breaking things.
gunicorn.sixis removed ingunicorn > 20.0This line here:
https://github.com/materialsproject/fireworks/blob/6505cd52ca3a7f34b549e6a18c7e2d0d336aa066/fireworks/flask_site/gunicorn.py#L7-L9
still tries to import
iteritemfrom it. The easy fix is to tell it import fromsixinstead.As a result, anyone with
gunicorn>20.0will get a message saying they need to installgunicorn.As a general problem, I can see that
setup.pyonly requires versions of dependencies to be higher than a particular release.https://github.com/materialsproject/fireworks/blob/e33821518acf4dc7276aa161a523a0770a776191/setup.py#L32-L37
If assuming semantic versioning, it would be better to pin them below the next major release number, in case of future non-compatible release breaking things.