search

materialsproject / fireworks

The Fireworks Workflow Management Repo.
https://materialsproject.github.io/fireworks
Other
361 stars 185 forks source link

Updating urls in the templates #435

Closed fekad closed 3 years ago

fekad commented 3 years ago

To allow to use url prefixes all url should contain the base_url path as prefix. Flask has the url_for helper function that can be used not only for the static files but for all urls.

fekad commented 3 years ago

Hi @computron, @utf! Could you please have a look at this pull request? We would like to use the GUI of the fireworks inside a jupytehub/jupyterlab framework (https://github.com/fekad/jupyter-fireworks-proxy) which doesn't work with hardcoded absolute paths.

davidwaroquiers commented 3 years ago

Thanks @fekad for pushing this, @utf and @computron we are actually giving a tutorial on fireworks in the framework of Nomad next week (11 May) and it would be nice to have this pull request merged by that time (we are using this feature in the docker used for the tutorial). I don't know if this is feasible.

Best,

David

fekad commented 3 years ago

Hi @computron, do you have any thoughts on this one?

fekad commented 3 years ago

Hi @computron, do you have any thoughts on this one? If you are simply not interested in please let me know and I close this PR and depreciate jupyter-fireworks-proxy package from pip.

fekad commented 3 years ago

Closing due to the lack of interest!