Some format string fixes and upgrades

materialsproject / fireworks

The Fireworks Workflow Management Repo.

https://materialsproject.github.io/fireworks

Other

351 stars 184 forks source link

Closed janosh closed 2 years ago

janosh commented 2 years ago

Only the first two commits in this PR are actual fixes.

The other two are just

upgrading the remaining "".format() strings to f-strings (which make errors like that fixed in 2nd commit impossible) (not sure why pyupgrade left some of them) and
joining awkwardly split strings (e.g. "Gunicorn is required for server mode. " "Install using `pip install gunicorn`." -> "Gunicorn is required for server mode. Install using `pip install gunicorn`.").

janosh commented 2 years ago

69895b3 addresses cases where rounding errors lead to ugly C/(C+F):

computron commented 2 years ago

Thanks!