search

materialsproject / fireworks

The Fireworks Workflow Management Repo.
https://materialsproject.github.io/fireworks
Other
361 stars 185 forks source link

use blueprint for lpad gui #472

Open tschaume opened 2 years ago

tschaume commented 2 years ago

Converting lauchpad GUI to a Flask Blueprint to allow for it to be mounted at a different prefix/application root @mkhorton @shreddd

mkhorton commented 2 years ago

Thanks @tschaume. Can I confirm that, to your knowledge, there are no breaking changes in this PR?

@computron This PR is to allow us to more easily deploy FW dashboards for multiple people on NERSC infrastructure but should otherwise not affect dashboards for regular users.

tschaume commented 2 years ago

@mkhorton There shouldn't be breaking changes but the commented-out part in fireworks/scripts/lpad_run.py needs to be tested.

computron commented 2 years ago

@mkhorton @tschaume I'm trying to catch up on some PRs - could you let me know the current status of this? It looks like some tests are failing but maybe they just need a quick rerun or check

tschaume commented 2 years ago

@shreddd and @mkhorton have used the blueprint successfully already I think. Based on what's in this PR, this part needs reimplementation to work with blueprints.