search

materialsproject / fireworks

The Fireworks Workflow Management Repo.
https://materialsproject.github.io/fireworks
Other
351 stars 184 forks source link

Update requirements.txt #486

Closed hadeelsharaf closed 1 year ago

hadeelsharaf commented 2 years ago

to fix an issue when running the workflows on windows.

Error from Traceback : 

  File "D:\PY3\lib\site-packages\fireworks\utilities\tests\test_visualize.py", line 1, in <module>
    import pytest
ModuleNotFoundError: No module named 'pytest'
Andrew-S-Rosen commented 2 years ago

We probably don't want to add pytest as a requirement and should fix the source of the issue instead. @janosh, this seems related to a change you recently made, right?

janosh commented 2 years ago

@arosen93 Yes, this looks like the same error discussed in https://github.com/materialsproject/fireworks/pull/483#issuecomment-1059212580. I believe the error is already fixed on main so the first thing to try would be to release a new version. Not sure if anyone besides @computron can do that? @jmmshn also pinged @mkhorton, so maybe he can too?

Regarding this PR, setuptools doesn't actually look at requirements.txt so adding pytest there wouldn't help. It would need to be in setup.py.

Andrew-S-Rosen commented 2 years ago

Thanks for the reply. I will chat with folks here to see how we can get a new version released. This PR can probably be closed thereafter.

ardunn commented 2 years ago

Thanks for the reply. I will chat with folks here to see how we can get a new version released. This PR can probably be closed thereafter.

I believe @computron or @mkhorton can make a release, tagging them here in case one of them is interested

janosh commented 1 year ago

Closing this as already fixed.