materialsproject / fireworks

The Fireworks Workflow Management Repo.
https://materialsproject.github.io/fireworks
Other
351 stars 184 forks source link

Remove Unused Dependency: Six #511

Closed gdrosos closed 1 year ago

gdrosos commented 1 year ago

Summary

This pull request proposes the removal of the unused six dependency from the setup.py configuration file. It's part of an ongoing research endeavor focusing on the identification and elimination of code bloat within software projects. Your insights on this would be really valuable.

Rationale

The six library was initially introduced to the project in commit 3054682 for its use infireworks/core/firework.py. However, it was subsequently removed from the source code in commit a0db49d and also removed from the setup configuration file in pull request #464. Interestingly, it was reintroduced in commit 26786f5 in the setup.py without being directly invoked in the source code.

Given the above, removing this unused dependency will significantly benefit the project. It will not only reduce the overall size of the installed packages but also simplify the dependency tree and mitigate potential security risks.

Changes

Impact

janosh commented 1 year ago

Thanks @gdrosos !

gdrosos commented 1 year ago

Thank you very much @janosh for the immediate response! Have a nice day!