materialsproject / fireworks

The Fireworks Workflow Management Repo.
https://materialsproject.github.io/fireworks
Other
362 stars 185 forks source link

Adaptions to ruamel.yaml new API #517

Closed ikondov closed 8 months ago

ikondov commented 10 months ago

Closes #516

Summary

Starting from release 0.15, ruamel.yaml has introduced a new API. Starting with ruamel.yaml release 0.18 the old interface used in fireworks is depricated and removed. A future deprecation warning is shown with the releases in between. The warning turns into an AttributeError with ruamel.yaml >=18.0 (see issue #516 for more details).

Major changes:

Todos

If this is work in progress, what else needs to be done?

Checklist

Tip: Install pre-commit hooks to auto-check types and linting before every commit:

pip install -U pre-commit
pre-commit install
ikondov commented 10 months ago

Unortunately, I had to increase the ruff line-length to 180 in pyproject.toml because there are very long lines (not from me) in one of the tests and pre-commit (as suggested in the pull request template) did not allow me to commit.