Logging in rocket.py and launch_rocket.py - Githubissues

materialsproject / fireworks

The Fireworks Workflow Management Repo.

https://materialsproject.github.io/fireworks

Other

361 stars 185 forks source link

Logging in rocket.py and launch_rocket.py #518

Closed ikondov closed 7 months ago

ikondov commented 9 months ago

Closes #514

Summary

Some logging in the modules rocket.py and rocket_launcher.py has unexpected behavior. See issue #514 for more details.

Major changes:

Describe in the docs the logging level used in rocket.py
Replace print() with logger.log()

Todos

If this is work in progress, what else needs to be done?

Checklist

[ ] Google format doc strings added. Check with ruff.
[ ] Type annotations included. Check with mypy.
[ ] Tests added for new features/fixes.
[ ] If applicable, new classes/functions/modules have duecredit @due.dcite decorators to reference relevant papers by DOI (example)

Tip: Install pre-commit hooks to auto-check types and linting before every commit:

pip install -U pre-commit
pre-commit install