materialsproject / jobflow

jobflow is a library for writing computational workflows.
https://materialsproject.github.io/jobflow
Other
90 stars 24 forks source link

Match `atomate2` `ruff` config #464

Closed janosh closed 10 months ago

janosh commented 10 months ago

I don't think we should ignore PT011: pytest-raises-too-broad long-term. Better to add match="expected error message" to all pytest.raises(). But there were 45 violations so I didn't fix all of them.

codecov[bot] commented 10 months ago

Codecov Report

Merging #464 (a34e772) into main (abca261) will decrease coverage by 0.01%. The diff coverage is 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #464 +/- ## ========================================== - Coverage 99.86% 99.86% -0.01% ========================================== Files 20 20 Lines 1523 1516 -7 Branches 419 419 ========================================== - Hits 1521 1514 -7 Misses 2 2 ``` | [Files](https://app.codecov.io/gh/materialsproject/jobflow/pull/464?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=materialsproject) | Coverage Δ | | |---|---|---| | [src/jobflow/core/flow.py](https://app.codecov.io/gh/materialsproject/jobflow/pull/464?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=materialsproject#diff-c3JjL2pvYmZsb3cvY29yZS9mbG93LnB5) | `100.00% <ø> (ø)` | | | [src/jobflow/core/reference.py](https://app.codecov.io/gh/materialsproject/jobflow/pull/464?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=materialsproject#diff-c3JjL2pvYmZsb3cvY29yZS9yZWZlcmVuY2UucHk=) | `100.00% <100.00%> (ø)` | | | [src/jobflow/core/state.py](https://app.codecov.io/gh/materialsproject/jobflow/pull/464?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=materialsproject#diff-c3JjL2pvYmZsb3cvY29yZS9zdGF0ZS5weQ==) | `100.00% <ø> (ø)` | | | [src/jobflow/core/store.py](https://app.codecov.io/gh/materialsproject/jobflow/pull/464?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=materialsproject#diff-c3JjL2pvYmZsb3cvY29yZS9zdG9yZS5weQ==) | `100.00% <100.00%> (ø)` | | | [src/jobflow/managers/fireworks.py](https://app.codecov.io/gh/materialsproject/jobflow/pull/464?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=materialsproject#diff-c3JjL2pvYmZsb3cvbWFuYWdlcnMvZmlyZXdvcmtzLnB5) | `100.00% <100.00%> (ø)` | | | [src/jobflow/managers/local.py](https://app.codecov.io/gh/materialsproject/jobflow/pull/464?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=materialsproject#diff-c3JjL2pvYmZsb3cvbWFuYWdlcnMvbG9jYWwucHk=) | `100.00% <100.00%> (ø)` | | | [src/jobflow/utils/enum.py](https://app.codecov.io/gh/materialsproject/jobflow/pull/464?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=materialsproject#diff-c3JjL2pvYmZsb3cvdXRpbHMvZW51bS5weQ==) | `100.00% <100.00%> (ø)` | | | [src/jobflow/utils/find.py](https://app.codecov.io/gh/materialsproject/jobflow/pull/464?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=materialsproject#diff-c3JjL2pvYmZsb3cvdXRpbHMvZmluZC5weQ==) | `100.00% <100.00%> (ø)` | | | [src/jobflow/utils/graph.py](https://app.codecov.io/gh/materialsproject/jobflow/pull/464?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=materialsproject#diff-c3JjL2pvYmZsb3cvdXRpbHMvZ3JhcGgucHk=) | `100.00% <100.00%> (ø)` | |