materialsproject / jobflow

jobflow is a library for writing computational workflows.
https://materialsproject.github.io/jobflow
Other
90 stars 24 forks source link

Fix JobStoreDocument validator #478

Closed utf closed 10 months ago

utf commented 10 months ago

I found that the validator in the JobStoreDocument introduced in #424 was causing atomate2 to stop working. I can't see why this validator is actually needed, it will just slow things down, so I removed it.

codecov[bot] commented 10 months ago

Codecov Report

Merging #478 (66296ea) into main (beb78b1) will decrease coverage by 0.01%. Report is 4 commits behind head on main. The diff coverage is 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #478 +/- ## ========================================== - Coverage 99.86% 99.86% -0.01% ========================================== Files 20 20 Lines 1516 1508 -8 Branches 419 415 -4 ========================================== - Hits 1514 1506 -8 Misses 2 2 ``` | [Files](https://app.codecov.io/gh/materialsproject/jobflow/pull/478?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=materialsproject) | Coverage Δ | | |---|---|---| | [src/jobflow/core/job.py](https://app.codecov.io/gh/materialsproject/jobflow/pull/478?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=materialsproject#diff-c3JjL2pvYmZsb3cvY29yZS9qb2IucHk=) | `100.00% <100.00%> (ø)` | | | [src/jobflow/core/schemas.py](https://app.codecov.io/gh/materialsproject/jobflow/pull/478?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=materialsproject#diff-c3JjL2pvYmZsb3cvY29yZS9zY2hlbWFzLnB5) | `100.00% <100.00%> (ø)` | | | [src/jobflow/core/store.py](https://app.codecov.io/gh/materialsproject/jobflow/pull/478?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=materialsproject#diff-c3JjL2pvYmZsb3cvY29yZS9zdG9yZS5weQ==) | `100.00% <ø> (ø)` | |