search

materialsproject / jobflow

jobflow is a library for writing computational workflows.
https://materialsproject.github.io/jobflow
Other
90 stars 25 forks source link

Fix tutorial bug #505

Closed mcgalcode closed 7 months ago

mcgalcode commented 7 months ago

Summary

Fixes a bug where re-running a cell in the intro notebook would lead to a "job used in multiple flows error". Addresses point 2) in the JOSS review issue.

Addresses point number 2) in

Checklist

Before a pull request can be merged, the following items must be checked:

Note that the CI system will run all the above checks. But it will be much more efficient if you already fix most errors prior to submitting the PR. It is highly recommended that you use the pre-commit hook provided in the repository. Simply cp pre-commit .git/hooks and a check will be run prior to allowing commits.

codecov[bot] commented 7 months ago

Codecov Report

Merging #505 (0e820fd) into main (8ffcf52) will not change coverage. The diff coverage is n/a.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #505 +/- ## ======================================= Coverage 99.86% 99.86% ======================================= Files 20 20 Lines 1512 1512 Branches 416 416 ======================================= Hits 1510 1510 Misses 2 2 ```
Andrew-S-Rosen commented 7 months ago

Thank you so much, @mcgalcode!! That will help users. @utf, this looks good to merge to me.

utf commented 7 months ago

Great, thanks!