materialsproject / jobflow

jobflow is a library for writing computational workflows.
https://materialsproject.github.io/jobflow
Other
90 stars 25 forks source link

Optionally avoid deserialization when resolving references #512

Closed gpetretto closed 6 months ago

gpetretto commented 7 months ago

Summary

Following the discussion about the need to deserialize objects when the output references are being resolved, I have added an option to avoid it. This would fail if the reference is a property of the deserialized object.

codecov[bot] commented 7 months ago

Codecov Report

Merging #512 (2917456) into main (0032693) will increase coverage by 0.00%. The diff coverage is 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #512 +/- ## ======================================= Coverage 99.86% 99.86% ======================================= Files 20 20 Lines 1512 1513 +1 Branches 415 416 +1 ======================================= + Hits 1510 1511 +1 Misses 2 2 ``` | [Files](https://app.codecov.io/gh/materialsproject/jobflow/pull/512?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=materialsproject) | Coverage Δ | | |---|---|---| | [src/jobflow/core/reference.py](https://app.codecov.io/gh/materialsproject/jobflow/pull/512?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=materialsproject#diff-c3JjL2pvYmZsb3cvY29yZS9yZWZlcmVuY2UucHk=) | `100.00% <100.00%> (ø)` | |
utf commented 6 months ago

This looks great, thanks @gpetretto