Closed jmmshn closed 6 months ago
Attention: 7 lines
in your changes are missing coverage. Please review.
Comparison is base (
9bd99a8
) 99.86% compared to head (923468b
) 99.42%.:exclamation: Current head 923468b differs from pull request most recent head 82ea1b5. Consider uploading reports for the commit 82ea1b5 to get more accurate results
Thanks for implementing the change and making uuid4 the default.
It would be convenient for me (and maybe for others), not to have an abrupt change in the exposed functions as I am using the suuid
function to generate a string uuid in a few places. It is not such a big deal, but would it be fine to keep the suuid
function in the uuid
module with a deprecation warning?
Yeah that makes sense.
BTW does anyone know what the s
in suuid
stands for?
Thanks @jmmshn.
Is it possible to make ulid
an optional dependency and only import it if the user has asked for it in their settings file. The code should also throw an appropriate error explaining which python package is needed to use ulid
if it is not installed.
The s
in suuid
stands for string
as we are encoding the UUIDs as strings not bytes.
Thanks @jmmshn
BTW, can we get a release with this, then I can finish the atomate2 PR.
Done (v0.1.17
)
Only allow UUIDs that can be sorted in time
Partially addresses: https://github.com/materialsproject/jobflow/issues/519
*uuid
->*uid
UID_TYPE
uuid1
andulid
viapython-ulid