Closed gpetretto closed 4 months ago
Great catch! Thanks @gpetretto
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
c211030
) 99.42% compared to head (0debb38
) 99.42%.
Is it possible to add a quick test?
Is it possible to add a quick test?
done
Perfect, thanks so much.
I have seen that in some cases the
JobFiretask
does not properly serialize a Job. Consider the case of a Maker with a Callable as an attribute.When running this, in the firework DB you have
Where the function is serialized as a string.
This PR addresses this issue by overriding the
JobFiretask.to_dict
method and explicitly jsanitizing the Job.