materialsproject / jobflow

jobflow is a library for writing computational workflows.
https://materialsproject.github.io/jobflow
Other
93 stars 24 forks source link

fix @job annotation (again) #579

Closed FabiPi3 closed 6 months ago

FabiPi3 commented 6 months ago

This is a follow-up of #578 . As it turns out, pycharm only reacts on the @overload if the original function is also annotated. This is also in agreement with mypy.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.42%. Comparing base (f27d2de) to head (65fd809).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #579 +/- ## ======================================= Coverage 99.42% 99.42% ======================================= Files 21 21 Lines 1570 1570 Branches 426 426 ======================================= Hits 1561 1561 Misses 9 9 ``` | [Files](https://app.codecov.io/gh/materialsproject/jobflow/pull/579?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=materialsproject) | Coverage Δ | | |---|---|---| | [src/jobflow/core/job.py](https://app.codecov.io/gh/materialsproject/jobflow/pull/579?src=pr&el=tree&filepath=src%2Fjobflow%2Fcore%2Fjob.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=materialsproject#diff-c3JjL2pvYmZsb3cvY29yZS9qb2IucHk=) | `100.00% <100.00%> (ø)` | |
utf commented 6 months ago

Thanks!