Open gpetretto opened 2 months ago
I'm not sure this behaviour is unexpected, since the Maker does not exist at the time update_maker_kwargs
is applied.
I'd support adding a dynamic
argument as you suggested. Although I feel like it should be set to False
by default since for some reason this feels more unexpected to me than the config/metadata case.
I have realized that the functions
update_kwargs
andupdate_maker_kwargs
do not apply to Jobs that are generated dynamically, unless the Maker that generates them is already instantiated when the Flow is created.Here is a minimal example:
whose output is
I am not sure if this is the intended behaviour, but I would have somehow expected this to work. Maybe a
dynamic
argument could be added to the two functions, similar to the one implemented forupdate_metadata
andupdate_config
(https://github.com/materialsproject/jobflow/pull/198)? I did not check if the procedure could be completely equivalent or adaptations will be needed.