Closed jmmshn closed 5 months ago
Attention: Patch coverage is 50.00000%
with 1 lines
in your changes are missing coverage. Please review.
Project coverage is 81.31%. Comparing base (
f88951d
) to head (819d187
).
Files | Patch % | Lines |
---|---|---|
src/maggma/core/builder.py | 50.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks @jmmshn !
Handle store Error during finalize
I assume the try/except in finalize is meant to handle situations where the store is already closed. https://github.com/materialsproject/maggma/blob/f88951d09b22795fc4e69dc29a6e552b0ab4f676/src/maggma/core/builder.py#L109-L118
However, closing a store: https://github.com/materialsproject/maggma/blob/f88951d09b22795fc4e69dc29a6e552b0ab4f676/src/maggma/stores/mongolike.py#L421-L426
can cause a StoreError if it's already closed. https://github.com/materialsproject/maggma/blob/f88951d09b22795fc4e69dc29a6e552b0ab4f676/src/maggma/stores/mongolike.py#L254-L258