search

materialsproject / maggma

MongoDB aggregation machine
https://materialsproject.github.io/maggma/
Other
38 stars 32 forks source link

Bump min `pyzmq>=25.1.1` for Python 3.12 compatibility #982

Closed janosh closed 4 months ago

janosh commented 4 months ago

25.1.1 is the first python 3.12 compatible pyzmq release

addresses https://github.com/materialsproject/jobflow/pull/640. @tschaume suggested @Andrew-S-Rosen and @rkingsbury as reviewers

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.76%. Comparing base (1188a57) to head (f34d8f5).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #982 +/- ## ======================================= Coverage 88.76% 88.76% ======================================= Files 46 46 Lines 3979 3979 ======================================= Hits 3532 3532 Misses 447 447 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Andrew-S-Rosen commented 4 months ago

I have no objections but also no merge rights :) that would be @rkingsbury and @munrojm.

rkingsbury commented 4 months ago

thanks @janosh !