materialsproject / mp-react-components

A suite of React components for the Materials Project, developed for use in Crystal Toolkit and the Materials Project public website.
https://materialsproject.github.io/mp-react-components/
17 stars 8 forks source link

TypeError: Cannot read properties of undefined (reading 'rotation') #635

Open Samonnite opened 2 years ago

Samonnite commented 2 years ago

https://materialsproject.github.io/mp-react-components/?path=/story/crystal-toolkit-crystaltoolkitscene--basic image

TypeError: Cannot read properties of undefined (reading 'rotation')
    at new InsetHelper (https://materialsproject.github.io/mp-react-components/main.0a4797d2.iframe.bundle.js:1:142840)
    at new Scene (https://materialsproject.github.io/mp-react-components/main.0a4797d2.iframe.bundle.js:1:160581)
    at https://materialsproject.github.io/mp-react-components/main.0a4797d2.iframe.bundle.js:1:196368
    at commitHookEffectListMount (https://materialsproject.github.io/mp-react-components/942.9c0eb5a4.iframe.bundle.js:2:4841045)
    at commitPassiveHookEffects (https://materialsproject.github.io/mp-react-components/942.9c0eb5a4.iframe.bundle.js:2:4842147)
    at HTMLUnknownElement.callCallback (https://materialsproject.github.io/mp-react-components/942.9c0eb5a4.iframe.bundle.js:2:4496053)
    at Object.invokeGuardedCallbackImpl (https://materialsproject.github.io/mp-react-components/942.9c0eb5a4.iframe.bundle.js:2:4496571)
    at invokeGuardedCallback (https://materialsproject.github.io/mp-react-components/942.9c0eb5a4.iframe.bundle.js:2:4497775)
    at flushPassiveEffectsImpl (https://materialsproject.github.io/mp-react-components/942.9c0eb5a4.iframe.bundle.js:2:4893102)
    at unstable_runWithPriority (https://materialsproject.github.io/mp-react-components/942.9c0eb5a4.iframe.bundle.js:2:5912597)
JoshDLane commented 1 year ago

any progress on this? is it just an issue in storybook?

Aaronphy commented 9 months ago

any progress on this? is it just an issue in storybook?

Hi, Do you know how to parse the CIF to the Scene JSON?