search

materialsproject / pymatgen-analysis-defects

Defect analysis modules for pymatgen
https://materialsproject.github.io/pymatgen-analysis-defects
Other
39 stars 10 forks source link

Patch Numba Dep #167

Closed jmmshn closed 9 months ago

jmmshn commented 9 months ago

Allow numba to be an optional Dep

all option optional deps are installed with 

pip install -e .[optional]
jmmshn commented 9 months ago

addressed #166

codecov[bot] commented 9 months ago

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (a28b25a) 90.83% compared to head (0412e49) 90.71%.

Files Patch % Lines
pymatgen/analysis/defects/recombination.py 40.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #167 +/- ## ========================================== - Coverage 90.83% 90.71% -0.13% ========================================== Files 11 11 Lines 2063 2067 +4 Branches 399 400 +1 ========================================== + Hits 1874 1875 +1 - Misses 102 105 +3 Partials 87 87 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.