Python Materials Genomics (pymatgen) is a robust materials analysis code that defines classes for structures and molecules with support for many electronic structure codes. It powers the Materials Project.
Currently a lot of global ignore patterns are very specific to a certain module (or even one line), there's no good reason to ignore a pattern globally for such cases. Admittedly it will be a balance between convenience (no one want to insert a # codespell:ignore tag every line) and correctness (some patterns are very specific to few lines across the code base, but are real typos elsewhere, like lamda/coul, do note).
Changes:
Keep the global pattern when it's very common: Elements like Nd/Te, or very common for a commonly used module, TITEL for VASP for example, or our good friend atomate
Rename some internal/test variables when it's not breaking (usually increase readability)
Ignore all JSON files as comments are not allowed in JSON, we might safely assume everything is intended in JSON
Follow up
[ ] Is it possible to add file-specific ignore tags (for example ignore ontop for adsorption.py, or coul for LAMMPS)? Currently codespell seems to provide block-level ignore tag but doesn't take a pattern
Cleanup
codespell
ignore patternsCurrently a lot of global ignore patterns are very specific to a certain module (or even one line), there's no good reason to ignore a pattern globally for such cases. Admittedly it will be a balance between convenience (no one want to insert a
# codespell:ignore
tag every line) and correctness (some patterns are very specific to few lines across the code base, but are real typos elsewhere, likelamda/coul
, do note).Changes:
Nd/Te
, or very common for a commonly used module,TITEL
for VASP for example, or our good friendatomate
Follow up
ontop
foradsorption.py
, orcoul
forLAMMPS
)? Currentlycodespell
seems to provide block-level ignore tag but doesn't take a pattern