search

materialsvirtuallab / matgl

Graph deep learning library for materials
BSD 3-Clause "New" or "Revised" License
233 stars 57 forks source link

[Bug]: Release workflow broken #191

Closed janosh closed 7 months ago

janosh commented 7 months ago

Email (Optional)

No response

Version

v0.8.6

Which OS(es) are you using?

What happened?

This doesn't look right. Skips the release step even when it shouldn't. You probably wan't if: github.event_name == 'release' && needs.tests.result == 'success'.

https://github.com/materialsvirtuallab/matgl/blob/d9f266523983fdea0baeacc16dece83f447e5a14/.github/workflows/testing.yml#L51

Hence https://github.com/materialsvirtuallab/matgl/releases/tag/v0.8.6 didn't make it to PyPI.

Code snippet

No response

Log output

No response

Code of Conduct

shyuep commented 7 months ago

I am unclear of the bug. This runs the release porition only when the event is release and needs: test already specifies that it should run only when the tests pass. What is the bug?

janosh commented 7 months ago

github.event.name doesn't exist. It's github.event_name.