materialsvirtuallab / matgl

Graph deep learning library for materials
BSD 3-Clause "New" or "Revised" License
256 stars 59 forks source link

model version for Potential class is modified #194

Closed kenko911 closed 10 months ago

kenko911 commented 10 months ago

Summary

The model version of the Potential class is changed from 1 to 2. This prevents the wrong loading of the model.

Checklist

Tip: Install pre-commit hooks to auto-check types and linting before every commit:

pip install -U pre-commit
pre-commit install
janosh commented 10 months ago

@kenko911 What do you need from me?

kenko911 commented 10 months ago

Hi @janosh, thanks for reporting the error. I just changed the model version and I would like to know if it fixes the error you reported in #193😁?

janosh commented 10 months ago

@shyuep already fixed the error in v0.9.0.

shyuep commented 10 months ago

@janosh Yes it is fixed. But this is more for future-proofness. We want a proper versioning of model so that the cache invalidation works properly. It is not related to the tests in pymatgen/downstream codes.