Little cleanup in so3.py and _so3.py

materialsvirtuallab / matgl

Graph deep learning library for materials

BSD 3-Clause "New" or "Revised" License

232 stars 57 forks source link

Little cleanup in so3.py and _so3.py #231

Closed kenko911 closed 4 months ago

kenko911 commented 4 months ago

Summary

remove unnecessary .cpu() in so3.py and _so3.py

Checklist

[x] Google format doc strings added. Check with ruff.
[x] Type annotations included. Check with mypy.
[x] Tests added for new features/fixes.
[x] If applicable, new classes/functions/modules have duecredit @due.dcite decorators to reference relevant papers by DOI (example)

Tip: Install pre-commit hooks to auto-check types and linting before every commit:

pip install -U pre-commit
pre-commit install

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (e9383cf) 98.80% compared to head (95a0f33) 98.79%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #231 +/- ## ========================================== - Coverage 98.80% 98.79% -0.01% ========================================== Files 33 33 Lines 2750 2749 -1 ========================================== - Hits 2717 2716 -1 Misses 33 33 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.