Closed kenko911 closed 1 week ago
The primary change in tests/layers/test_core_and_embedding.py
involved modifying the test_mlp_norm
function within the TestCoreAndEmbedding
class to pass an additional argument, normalize_hidden=True
, to the MLP_norm
layer. This ensures that the hidden states are normalized during testing.
File | Change Summary |
---|---|
tests/layers/test_core_and_embedding.py |
Modified test_mlp_norm function to include normalize_hidden=True . |
tests/layers/test_core_and_embedding.py (1)
`51-51`: **LGTM!** The addition of `normalize_hidden=True` aligns with the PR objectives to enhance the `MLP_norm` class functionality. Ensure that this change is reflected in any other tests or usage scenarios where `MLP_norm` is involved.
Summary
Improve the coverage in MLP_norm class
Checklist
ruff
.mypy
.duecredit
@due.dcite
decorators to reference relevant papers by DOI (example)Tip: Install
pre-commit
hooks to auto-check types and linting before every commit: