matestack / matestack-ui-core

Component based web UIs in pure Ruby for Rails. Boost your productivity & easily create component based web UIs in pure Ruby.
https://www.matestack.io
MIT License
547 stars 47 forks source link

fix(select component): fix rendering of placeholder #574

Closed aaron-contreras closed 2 years ago

aaron-contreras commented 2 years ago

Make the value property render in the HTML option element used as a placeholder

re #573

Seems to be no develop branch

Issue 573: select placeholder not rendered properly

Changes

Notes

jonasjabari commented 2 years ago

Hey @aaron-contreras Thank you so much for this PR. I was not able to review it properly until now! I will do so asap! But it seems legit to me. Just need to check on some specs we have in place around this context!

Cheers, Jonas

aaron-contreras commented 2 years ago

Thanks for getting back to me on this @jonasjabari. Are there some requirements to become a frequent contributor to this project?

jonasjabari commented 2 years ago

Hey @aaron-contreras! I've merged you PR in a matestack branch in order to run it on the CI. All green, now merged to develop :)

And let's have an intro call! I'm happy to add you the the team to become a frequent contributor!