search

mateus-amarante / awesome-robotics-brazil

:sunglasses: Awesome list of robotics initiatives in Brazil
Creative Commons Zero v1.0 Universal
46 stars 8 forks source link

Added GitHub/Gitlab repos #15

Closed h3ct0r closed 3 years ago

h3ct0r commented 3 years ago

Hi!, in this PR I added some Git repos using the :octocat: link scheme and added a new drone company to the list. :)

edit: There is a lint warning if there is a dash in the link title and the git link is also present. For example this list item raise an error: :exclamation: VeRLab - Laboratório de Visão Computacional e Robótica (UFMG) :octocat:

And this version does not: :heavy_check_mark: VeRLab - Laboratório de Visão Computacional e Robótica (UFMG) :octocat:

Regards,

h3ct0r commented 3 years ago

Regarding the problem you mentioned, I think it is better to keep the entire name inside the link and place the symbol after the dash. In this way, they will be similar to the other items. What do you think?

Yes, I liked that way too! I have just made a small change to comply with the linter. If there are no more changes to do, we could merge this with main!

mateus-amarante commented 3 years ago

Just a comment: it is possible to group commit suggestions in batches as this tutorial explains