mateuskreuch / minecraft-miniature-shader

In-style lighting and reflection shader for Minecraft
MIT License
11 stars 0 forks source link

Normals are skewed and flat on Iris #7

Closed onkoe closed 2 months ago

onkoe commented 5 months ago

Describe the bug Using Iris 1.6.14 on Minecraft 1.20.4 and Fabric Loader 1.15.3, there are many artifacting and rendering bugs.

To Reproduce Steps to reproduce the behavior:

  1. Unknown. Sorry!
  2. Try installing Iris on Fabric, though!

Expected behavior Screenshots that look like those on Modrinth.

Screenshots 2024-01-14_20 44 04 2024-01-14_20 44 13

System Information

Additional context You can find more information about my hardware specs using this report: https://linux-hardware.org/?probe=29d93a66fe

onkoe commented 5 months ago

note: Also reproducible with a subset of those mods:

  [✔] fabric-api-0.93.1+1.20.4
  [✔] fabric-language-kotlin-1.10.17+kotlin.1.9.22
  [✔] fabricskyboxes-0.7.3+mc1.20.2
  [✔] indium-1.0.28+mc1.20.4
  [✔] iris-mc1.20.4-1.6.14
  [✔] modmenu-9.0.0
  [✔] reeses_sodium_options-1.7.0+mc1.20.2-build.97
  [✔] sodium-extra-0.5.3+mc1.20.2-build.114
  [✔] sodium-fabric-mc1.20.3-0.5.5
mateuskreuch commented 5 months ago

I can't reproduce it. Does it work fine with just Iris?

onkoe commented 5 months ago

No - with Iris and Sodium (bare minimum) enabled, the artifacting still occurs.

Can I provide any other logs/etc. for additional troubleshooting?

mateuskreuch commented 5 months ago

Does it happen in Miniature 1.10? And does disabling waves in the current version help at all?

onkoe commented 5 months ago

The 'artifcating' doesn't occur on the older version - nor when waves are turned off. However, there are still issues with general skewing. For example, in the screenshots below, reflections show parts of the world that they shouldn't see!

2.4.6

2024-01-16_01 20 57 2024-01-16_01 21 02

1.10

2024-01-16_01 20 16 2024-01-16_01 20 24 2024-01-16_01 20 32

mateuskreuch commented 5 months ago

Can you test this build for me and see if it is any better?

mateuskreuch commented 2 months ago

Closing because of inactivity.