search

mateuszbuda / ThermometerExtended2

ThermometerExtended with fragments
MIT License
6 stars 3 forks source link

cannot find symbol: dataSeries.getValues() #17

Closed grote closed 10 years ago

grote commented 10 years ago

When compiling I get errors like this one:

src/pl/narfsoftware/thermometer/ui/PlotFragment.java:157: error: cannot find symbol
    [javac]             if (dataSeries.getValues().length <= 1) {
    [javac]                           ^
    [javac]   symbol:   method getValues()
    [javac]   location: variable dataSeries of type GraphViewSeries

I tried using various versions of the GraphView library without success.

mateuszbuda commented 10 years ago

Try my fork -> [https://github.com/mateuszbuda/GraphView-2]

grote commented 10 years ago

Forking an upstream library for no good reasons is usually not a good idea. Do you have any plans of getting your changes merged with upstream?

mateuszbuda commented 10 years ago

So far I didn't made any significant changes. In not yet specified future I want to add interpolation in order to smooth a plot. If I used upstream library I would not be able to catch up with changes. That's why i decided to fork.

grote commented 10 years ago

If your change makes sense upstream will merge it. A library normally doesn't move that much, but you decide which version of the lib you use. Git submodules work nice to manage that.

For now, I'll try to use your fork.

grote commented 10 years ago

Compiling works now. Prepare to be added to F-Droid: https://gitlab.com/fdroid/fdroiddata/merge_requests/29/diffs