math-comp / analysis

Mathematical Components compliant Analysis Library
Other
200 stars 44 forks source link

Order topology #1318

Closed zstone1 closed 2 weeks ago

zstone1 commented 3 weeks ago

With pointed stuff out of the way, we can start really mixing types for great good! The adds

Checklist

Reference: How to document

Reminder to reviewers
affeldt-aist commented 2 weeks ago

Ah but maybe rray_open was right in the first place since MathComp conventions require this format mainSymbol_unaryPredicate for unary predicate, this is open_lt and the like that we have to rename

zstone1 commented 2 weeks ago

Yes, that makes sense. We'll have a chance to clean up the names as this order stuff evolves. I've pushed with

  1. Moving the stuff from lebesgue into set_interval
  2. I added a lemma that shows the definitions are related (but not equal! the converse is false).
  3. Keeping the lray_open style names
affeldt-aist commented 2 weeks ago

Line 4082 "From mathcomp Require Import set_interval." can probably be removed

affeldt-aist commented 2 weeks ago

Ah, I almost forgot, should we take care of the renaming of, e.g., https://github.com/math-comp/analysis/blob/ad764a4d62d84c5d406eb9197431945f76ef5655/theories/normedtype.v#L1192 along this PR? What would be a better name for it that looks like lray_open? rlray_open?

zstone1 commented 2 weeks ago

I was planning on doing that in a follow up where we rename and generalize from R to any order topology.