math-comp / hierarchy-builder

High level commands to declare a hierarchy based on packed classes
MIT License
95 stars 20 forks source link

improve HB.instance #421

Closed gares closed 2 months ago

gares commented 2 months ago
CohenCyril commented 2 months ago

The real bench is mca, I just added it, and I'm running it on my computer this afternoon (MCA takes about 20min if I recall correctly)

proux01 commented 2 months ago

@CohenCyril https://github.com/coq-community/coq-nix-toolbox/pull/224 merged, could you please update the toolbox and rerun CI here

proux01 commented 2 months ago

CI green, this looks good to be (squashed and) merged

gares commented 2 months ago

I still don't get why XS and elements {make-set XS} make any difference for ssrnum, but I guess I'll have to live with that.

There was a hack in ssrnum, maybe @CohenCyril recalls it? I don't think it should impact here though.

proux01 commented 2 months ago

The failure was about SemiGroup and Monoids, didn't felt like related to the hack (but maybe remotely who knows).

proux01 commented 2 months ago

FTR

gares commented 2 months ago

We could also try with the version of toposort by @Tragicus but we need elpi 1.19.2 for an efficient coq.gref.set.fold