math-comp / hierarchy-builder

High level commands to declare a hierarchy based on packed classes
MIT License
95 stars 20 forks source link

The notation Structure.on and Structure.Build should be better scoped #430

Open CohenCyril opened 2 months ago

CohenCyril commented 2 months ago

Indeed, writing Equality.on (nat * nat) will mistakenly interpret * as being the natural number multiplication instead of the cartesian product. The same goes for Build.

We should use the scope given by the type of the argument, and allow manual overriding from the user.

Spotted by @ggonthier