math-comp / mcb

Mathematical Components (the Book)
Other
140 stars 25 forks source link

further corrections(?) #137

Open darijgr opened 3 years ago

darijgr commented 3 years ago
gares commented 3 years ago

Thanks, I'll carefully review this pr later today

gares commented 3 years ago

@darijgr I had a little chat with @ybertot and we believe that the best way forward for this PR is that you split into two parts: one containing the minor fixes, typos, etc which can be merged fast, and another one with the last big chunk which requires more thinking, especially on our side (the book was written a long ago, we need to put your change into context to review it).

Thanks again for your contribution.

darijgr commented 3 years ago

@gares Done what you said. Now this branch has the relatively straightforward edits, whereas the implicit argument rewrite is at https://github.com/darijgr/mcb/tree/sugg2b .