Open SnarkBoojum opened 2 years ago
Playing with complex numbers, I can't help but notice that some computations are pretty ugly:
Computations are not meant to work and cannot be made to work for such complex datatypes. The internal representation of algebraic numbers should not be exposed.
There's also a lemma where I have the following line, just for 'i * 'i = -1:
rewrite -[(_ +i* _) * (_ +i* _)]/(_ +i* _) !mul0r mulr0 mulr1 !add0r complexr0 in H.
There is a generic theorm:
https://github.com/math-comp/math-comp/blob/1f0daa44f834a040367f5fcb44451571fc9b646b/mathcomp/algebra/ssrnum.v#L4382-L4383
Actually, many theorems for complex algebraic numbers are derived from the theory of numClosedField
in mathcomp.algebra.ssrnum
.
Playing with complex numbers, I can't help but notice that some computations are pretty ugly:
There's also a lemma where I have the following line, just for 'i * 'i = -1:
Perhaps there's something to be done to improve matters?