math-dojo / user-account-service

Microservice for managing the users of the math-dojo platform
1 stars 0 forks source link

Enable New User to be created with a Custom Id #42

Closed aakano684 closed 3 years ago

aakano684 commented 4 years ago

⚠️⚠️ ⚠️ All PRs must have a version of the format pr${number} and an override target url set up on the user-accout-test api ⚠️ ⚠️ ⚠️

Purpose

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install

What to Check

Verify that the following are valid

Other Information

noce2 commented 4 years ago

We've added some new functionality but it seems we haven't added any new tests against it? It might not mean new unit tests per se but I would have expected that we'd modify the unit tests we've got in say the Identity Service and the assertions we perform against a created user in the integration tests.

noce2 commented 3 years ago

This resolves #26