math-dojo / user-account-service

Microservice for managing the users of the math-dojo platform
1 stars 0 forks source link

Develop -> Master: Fix Broken Preprod + Enable Custom User ID on Registration #43

Closed noce2 closed 3 years ago

noce2 commented 3 years ago

⚠️⚠️ ⚠️ All PRs must have a version of the format pr${number} and an override target url set up on the user-accout-test api ⚠️ ⚠️ ⚠️

Purpose

Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type

What kind of change does this Pull Request introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install

What to Check

Verify that the following are valid

Other Information

noce2 commented 3 years ago

/azp run

azure-pipelines[bot] commented 3 years ago
No pipelines are associated with this pull request.
noce2 commented 3 years ago

78a89e1 is failing because of the Integration Tests. The registered API version for this PR expired a little while ago so all that's needed is to reinstate the version (pr43). Currently facing issues with login on the Tyk cloud dashboard so will try this again later.