math1um / objects-invariants-properties

Objects, Invariants and Properties for Graph Theory (GT) automated conjecturing: in particular with the Sage program CONJECTURING: http://nvcleemp.github.io/conjecturing/
GNU General Public License v3.0
15 stars 6 forks source link

number_of_triangles disappeared #562

Closed nvcleemp closed 6 years ago

nvcleemp commented 6 years ago

The invariant number_of_triangles introduced in 4ea089481bdcdcc6b8deb9a88e7c68374f4a048e has since disappeared. This is especially problematic since there are some theorems which still refer to it, and thus are currently broken.

Was there a mistake in this invariant, or was it just removed by accident?

math1um commented 6 years ago

Graph.triangles_count is a method now, and included in the invariants list. Maybe someone just removed the one we coded after the method became available?

nvcleemp commented 6 years ago

No, for some time neither were in the repository. But fine, we have a replacement now.

nvcleemp commented 6 years ago

All of the occurrences of number_of_triangles have been replaced by Graph.triangles_count.