search

math1um / objects-invariants-properties

Objects, Invariants and Properties for Graph Theory (GT) automated conjecturing: in particular with the Sage program CONJECTURING: http://nvcleemp.github.io/conjecturing/
GNU General Public License v3.0
14 stars 6 forks source link

minimum_maximal_matching_size is broken #603

Open yirkajk opened 6 years ago

yirkajk commented 6 years ago

Error: <type 'exceptions.AttributeError'> 'list' object has no attribute 'degree'

Problem is in this function's call to is_matching.

math1um commented 6 years ago

is_matching is terribly written.

should it: 1) take a graph and a set of edges and check if the set of edges is a matching, or 2) should it take a graph and check if that graph has no incident edges ?

in case (2), what the current code seems to attempt, is to check if for g, g.size() == 2*g.order()

nvcleemp commented 6 years ago

in case (2) it should just check that the minimum and maximum degree is 1.

nvcleemp commented 6 years ago

There is another issue: there are two functions named is_matching. One in properties and one in utilities. The one in utilities seems to be a correct implementation of case (2)