Open flabowski opened 1 month ago
I figured out that this must be for the StandardScaler
from scikit-learn. I think this could be better documented.
scaler_parameters
and scaler_snapshots
should be removed, since they are no longer used.
(In older versions, fit_transform
was called every time parameters
or snapshots
were referenced, meaning the scaler may change which can lead to unexpected behaviour...)I wondered if the scalers (scaler_parameters
and scaler_snapshots
) from the database should be removed elsewhere (e.g. in the ROM) as well? I think it was a good idea to separate the scaling from the ROM.
Is database.parameters
(and .snapshots) considered to be deprecated now in favour for database.parameters_matrix
?
Is your feature request related to a problem? Please describe. I would like to normalize / scale my snapshots and or the parameters using ezyrb.
Describe the solution you'd like
Describe alternatives you've considered I have looked into the optional keyword arguments
scaler_parameters
andscaler_snapshots
, they are used by calling their methodfit_transform
. I did not find any definition offit_transform
or how the scalers are supposed to be used.I am happy to contribute if you think that fits in your library and is not already possible in some other way.