search

mathLab / PyGeM

Python Geometrical Morphing
http://mathlab.github.io/PyGeM/
Other
338 stars 118 forks source link

Update khandler #183

Closed lukefarn1996 closed 4 years ago

lukefarn1996 commented 4 years ago

The original k handler indexed into the file to extract data assuming a specified spacing between node definitions and with a space delimiter. However the generation of .k files is not generic and therefore one with a different spacing between node positions will not work indexing numbers. The updated version uses a regex expression to extract data and is independent of the spacing or comma/space delimiter type.

lukefarn1996 commented 4 years ago

Example_kfile.zip Example k file, one from before a ffd and after.

mtezzele commented 4 years ago

Dear @lukefarn1996, I meant you can add the files in the folder and push to this PR, adding the corresponding tests. Now the tests for k files fail on travis, so I cannot merge this PR.

mtezzele commented 4 years ago

Dear @lukefarn1996 any news?

mtezzele commented 4 years ago

@lukefarn1996 may I close this?

lukefarn1996 commented 4 years ago

@lukefarn1996 may I close this?

Yes, the other pr has worked! Thanks.