search

mathLab / PyGeM

Python Geometrical Morphing
http://mathlab.github.io/PyGeM/
Other
338 stars 118 forks source link

Updated_khandler&Tests #187

Closed lukefarn1996 closed 4 years ago

lukefarn1996 commented 4 years ago

Updated KHandler and updated the tests to now contain a test to check for comma delimited .k files with examples.

lukefarn1996 commented 4 years ago

Hi @mtezzele, Managed to fix some of the tests however i keep getting "The command "conda info -a" failed and exited with 1 during ." from Travis in the build process.

mtezzele commented 4 years ago

Hi @mtezzele, Managed to fix some of the tests however i keep getting "The command "conda info -a" failed and exited with 1 during ." from Travis in the build process.

We are investigating this problem. I'll keep you updated.

mtezzele commented 4 years ago

I should have solved the conda problem with #189. @lukefarn1996 with a fetch+rebase this PR should pass.

mtezzele commented 4 years ago

Perfect, now the last thing @lukefarn1996 : can you do a fetch+rebase and/or a squash of your commits, please?

e-dub commented 3 years ago

Hi @mtezzele and @lukefarn1996: I am trying to get my LS-Dyna tutorials working again and the stopper are the changes discussed here to the khandler. The previous code works still while this does not. Is this an operating system issue? I am in Linux, you in Windows?

mtezzele commented 3 years ago

@e-dub please open an issue with a snippet of code replicating the error you get. Thanks.

e-dub commented 3 years ago

@mtezzele: See tutorial-6-k.py It is a script version of the tutorial.

The new version of the khandler gives the following error:

  File ~/opt/PyGeM/tutorials/tutorial-6-k.py", line 14, in <module>
    new_mesh_points = ffd(mesh_points)

  File "/usr/local/lib/python3.8/dist-packages/pygem-2.0.0-py3.8.egg/pygem/ffd.py", line 560, in __call__
    src_reference_frame_pts = self.psi(src_pts - self.box_origin)

ValueError: operands could not be broadcast together with shapes (0,) (3,)

With the old version of the khandler it works khandler.zip

mtezzele commented 3 years ago

@e-dub Open an issue please. You can link this PR from the issue. We should not continue here since this PR is closed.