search

mathLab / PyGeM

Python Geometrical Morphing
http://mathlab.github.io/PyGeM/
Other
342 stars 118 forks source link

added cffd and variations #268

Closed guglielmopadula closed 11 months ago

guglielmopadula commented 1 year ago

Hi, these are the modifications of the library used in the preprint https://arxiv.org/abs/2308.03662.

ndem0 commented 1 year ago

Dear @guglielmopadula, thanks for the additions! The contribution is very nice, but there are some gray point in the implementation. I started to left some comments, if you can please use also the code_formatter.sh before pushing in order to respect the code style (PEP8).

ndem0 commented 11 months ago

Dear @guglielmopadula, I just quickly looked at the new code and it's exactly what I meant! Perfect, thank you! Only one change please: the class VFFD and BFFD are now in the same file (cffd.py). It is not an error but I would consider to keep them in a separate files (no matter their length) in order to be more accessible by new users

ndem0 commented 11 months ago

Dear @guglielmopadula, now some of the tests are failing. Could you check? In your computer, is everything fine?

guglielmopadula commented 11 months ago

Yes, I and I see that in the ubuntu 3.7 version they don't fail, so maybe there are some problems with the virtual machines?